search

JuliaIDE / Reminisce

Sublime-style saving of tabs and content for Light Table
10 stars 3 forks source link

Handling restore for greater than one window #4

Open cldwalker opened 10 years ago

cldwalker commented 10 years ago

Hi, I noticed that when I open a second window, tab and workspace restoration kicks off, which is unexpected since those tabs and workspace were only for my first window. Is there plan to cache per window or to disable this restoration after the first window? If the latter, I could send a pull that just checks for (zero? (app/window-number)). For now, I've extended your plugin for myself. It would be great to solve this in your plugin since aggressive restoring doesn't play nicely with other plugins that depend on new windows. Thanks for your handy plugin!

MikeInnes commented 10 years ago

Just out of curiosity, what other plugins depend on new windows? I've never found using multiple windows to be that useful.

It should be possible to restore multiple windows in principle, though it would definitely require some changes. In the meantime a PR to check the window number would be welcome.

cldwalker commented 10 years ago

I use a new window when cloning a new github repo using gitbeam. If I'm only interacting with the repo temporarily, a new window serves nicely to not effect my current working window. Sent a PR

MikeInnes commented 10 years ago

Ah ok, nice – I'll have to check out gitbeam. I'll go look at that PR anyway