search

JuliaIO / BSON.jl

Other
158 stars 39 forks source link

Fixes issue 26 and 84 #90

Open mauro3 opened 3 years ago

mauro3 commented 3 years ago

Hopefully correctly this time around, first take was PR #29.

mauro3 commented 3 years ago

Note sure what the test-failure is about.

One thing to consider is (and maybe test) is what happens when one wants to store a BSONDict itself. Maybe best to error on that.

As a bit of a side-note: I don't know the code of BSON at all (apart from this PR), nor have a really spent time contemplating it's design. So, I will not be very useful for anything more than band-aids.