search

JuliaIO / CBOR.jl

A Concise Binary Object Representation (RFC 7049) serialization library in Julia
MIT License
19 stars 13 forks source link

made CBOR compatible with julia 0.4, 0.5, 0.6 #5

Closed chakravala closed 7 years ago

chakravala commented 7 years ago

Hello, please take these changes and create a new tag for METADATA as I intend to use this package in the future for a project.

This PR maintains backwards compatability with julia v0.4, v0.5, and v06. testing here

Tests for 0.7 passed on JuliaBox, but not on CI

Additionally, this also resolves issues #1 and pull requests #2 #3 #4

Please let me know if you received this :)

garborg commented 7 years ago

Hey @chakravala , looks like we made pretty identical PRs.

I think it's better to use yours since you made changes to the CI framework. Once this is merged, I'll close #6.

Re: supporting older versions, everything you did looks great. Supporting only 0.6 on would work well, too (as long as julia 0.6 went in the REQUIRE file.)

@saurvs, I'd go ahead and merge this one.

chakravala commented 7 years ago

Thanks for the input @garborg , I noticed your PR and realized that I forgot updating the README, which I then did. Since I wasn't sure if @saurvs is still relying on julia 0.4, I figured it would be best to support all three versions.

This could be a useful package in the future, so it would be great if this could be updated

saurvs commented 7 years ago

Hey @chakravala @garborg, thanks for the great work! I'm going to merge this PR.