Decode Operation - Githubissues

JuliaIO / GIFImages.jl

Provides Gif support in Julia using LibGif

https://ashwani-rathee.github.io/GIFImages.jl/dev/

MIT License

12 stars 2 forks source link

Decode Operation #4

Closed ashwani-rathee closed 2 years ago

ashwani-rathee commented 2 years ago

[x] Adds decode operation for GIFs

ashwani-rathee commented 2 years ago

Not entirely sure that we would be able to have 3 different types of inputs here as I don't see a function that read from Vector{UInt8}

Although if we are able to make DGifFileHandle work, then 2 methods of input become available. https://android.googlesource.com/platform/external/giflib/+/dc07290edccc2c3fc4062da835306f809cea1fdc/dgif_lib.c

johnnychen94 commented 2 years ago

No need to worry too much about this. It's okay to ship one feature at a time. Supporting IOBuffer() could be delayed to when we really need it.

ashwani-rathee commented 2 years ago

New method shows improvement of 15x

julia> @btime load(path); #imagemagick method
  30.908 ms (713080 allocations: 24.99 MiB)

julia> @btime gif_decode(path); #gifimages method
  2.589 ms (169 allocations: 537.73 KiB)

ashwani-rathee commented 2 years ago

I am still investigating the reason behind why it's failing in windows but issue is not related to this package but loading of libgifextra:

ERROR: LoadError: InitError: could not load library "C:\Users\runneradmin\.julia\artifacts\0fea2f7f9ede8707ffab3622b24de357a1773814\bin\libgifextra.dll"
The specified module could not be found.

I would generally want it to pass for windows too but I want to move forward with the PR and merge it to work on encode function and get the windows issue fixed eventually.