search

JuliaIO / GZip.jl

A Julia interface for gzip functions in zlib
https://juliaio.github.io/GZip.jl/dev
MIT License
39 stars 30 forks source link

gzopen(): use Libc.errno() #108

Closed alyst closed 9 months ago

alyst commented 9 months ago

I was trying to open the non-existing file, which triggered /lib/x86_64-linux-gnu/libc.so: Incorrect ELF header. When I replaced unsafe_load(cglobal((:errno, :libc), Cint)) with Libc.errno(), the issue got resolved, and I got the proper "Not such file or directory" error.

Fixes #106

alyst commented 9 months ago

CI failures don't look related

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e1206d5) 9.98% compared to head (559c9e8) 10.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #108 +/- ## ========================================== + Coverage 9.98% 10.15% +0.16% ========================================== Files 17 17 Lines 2374 2374 ========================================== + Hits 237 241 +4 + Misses 2137 2133 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alyst commented 9 months ago

@ViralBShah or @sjkelly, could you pls review the PR?

sjkelly commented 9 months ago

Thanks!