search

JuliaIO / GZip.jl

A Julia interface for gzip functions in zlib
https://juliaio.github.io/GZip.jl/dev
MIT License
39 stars 30 forks source link

Remove deprecation warnings on 0.4 #22

Closed garborg closed 9 years ago

garborg commented 9 years ago

As a bonus, takes care of the Task switching bug that's keeping DataFrames tests from running on 0.4

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-49.93%) to 3.76% when pulling a506d5ea6c8eb567b6d23345490165c0c795a4d8 on garborg:track04 into 810f3705d412d679b2e2d3f85c566570ebe5fa7e on JuliaLang:master.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-53.69%) to 0.0% when pulling 9a066f1832d2a10b3584a1d7595a3570e1496c3c on garborg:track04 into 810f3705d412d679b2e2d3f85c566570ebe5fa7e on JuliaLang:master.

garborg commented 9 years ago

Argh, forgot the requisite Compat patch was still waiting on Travis. Restarted -- apologies for the noise.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+15.39%) to 69.08% when pulling c1f70c7e7592439e0ae4b27c917913b6edf3f948 on garborg:track04 into 810f3705d412d679b2e2d3f85c566570ebe5fa7e on JuliaLang:master.

garborg commented 9 years ago

Error on 0.4 belongs to JuliaParser:

ERROR: LoadError: LoadError: LoadError: error in method definition: function Base.parse must be explicitly imported to be extended
...
while loading /home/travis/.julia/v0.4/JuliaParser/src/parser.jl, in expression starting on line 1864

Passes locally on 0.4.

jakebolewski commented 9 years ago

Hmm, fixing this is going to be a bit of a pain. I don't think I will get to it tonight.

garborg commented 9 years ago

Since the tests passed (no JuliaParser in the dependency tree) and the hang up was in Coveralls submission, does it makes sense to merge this in the meantime so I can tag a patch?

jakebolewski commented 9 years ago

Yes, go ahead.

garborg commented 9 years ago

I don't have the permissions (to merge here, fine for metadata).

garborg commented 9 years ago

Thanks!