Bandaid for gzseek bug on Windows

JuliaIO / GZip.jl

A Julia interface for gzip functions in zlib

https://juliaio.github.io/GZip.jl/dev

MIT License

39 stars 30 forks source link

Bandaid for gzseek bug on Windows #25

Closed carlobaldassi closed 9 years ago

carlobaldassi commented 9 years ago

zlib 1.2.8 has a bug on Windows, see https://github.com/madler/zlib/issues/95.

This is a bandaid for the common case of rewinding a stream. At least, in this way it would fix the issue for FastaIO.jl, which uses GZip.

carlobaldassi commented 9 years ago

The travis failure on nightly does not seem related to me (?).

coveralls commented 9 years ago

Coverage decreased (-0.76%) to 71.61% when pulling 0cca7adc66f1eb98a4dc04e67491a683e9dc512c on cb/gzseekwinfix into a01a29b71f6dae6e8cfa11776f3ef4fe205438d3 on master.

coveralls commented 9 years ago

Coverage decreased (-0.29%) to 72.08% when pulling f99b0ed5906343853be8e0e590b0c4e63b29a69f on cb/gzseekwinfix into a01a29b71f6dae6e8cfa11776f3ef4fe205438d3 on master.

coveralls commented 9 years ago

Coverage decreased (-0.29%) to 72.08% when pulling f99b0ed5906343853be8e0e590b0c4e63b29a69f on cb/gzseekwinfix into a01a29b71f6dae6e8cfa11776f3ef4fe205438d3 on master.

carlobaldassi commented 9 years ago

Based on my tests, the updated version should be able to fix the issue under Windows in all situations, not just seeking to zero.

Any objections to merging this?

kmsquire commented 9 years ago

Go for it!

On Friday, April 10, 2015, Carlo Baldassi notifications@github.com wrote:

Based on my tests, the updated version should be able to fix the issue under Windows in all situations, not just seeking to zero.

Any objections to merging this?

— Reply to this email directly or view it on GitHub https://github.com/JuliaLang/GZip.jl/pull/25#issuecomment-91538748.