search

JuliaIO / GZip.jl

A Julia interface for gzip functions in zlib
https://juliaio.github.io/GZip.jl/dev
MIT License
39 stars 30 forks source link

Update GZip.jl #29

Closed sbromberger closed 9 years ago

sbromberger commented 9 years ago

Remove deprecation warnings in latest 0.4

simonster commented 9 years ago

Probably needs JuliaLang/Compat.jl#107 not to break 0.3

sbromberger commented 9 years ago

of course. One sec.

sbromberger commented 9 years ago

Not sure why that test is failing.

tkelman commented 9 years ago

because https://github.com/JuliaLang/Compat.jl/issues/107 has not been fixed or tagged yet

alyst commented 9 years ago

I have no idea why, but with these deprecation warnings the GC state was not turning back on for me. Could it be because of depwarn()? So +1 to merging this PR ASAP. Also, should the GC state be saved and restored to the original one instead of "true"?

simonster commented 9 years ago

I just tagged a Compat.jl release that implements JuliaLang/Compat.jl#107. But there's no need to use the @compat macro here.

kmsquire commented 9 years ago

I restarted the build (which should pass), but as @simonster pointed out, you should remove @compat, as nothing needs to be rewritten.

garborg commented 9 years ago

@sbromberger Looks good. Squash the commits?

sbromberger commented 9 years ago

Not easily, I don't think - I edited within github.

garborg commented 9 years ago

Okay, I pushed your first commit to master b998284b9627361cab8c3a22e00191d19a1c09d1

sbromberger commented 9 years ago

Thanks. Sorry - I've been out all day.

garborg commented 9 years ago

No problem. Thanks for tracking down and fixing the issue.

sbromberger commented 9 years ago

My pleasure. Would you mind tagging so I can update my REQUIRE? Thanks!

garborg commented 9 years ago

Pending in JuliaLang/METADATA.jl#2824

sbromberger commented 9 years ago

Awesome! Thanks again.