search

JuliaIO / GZip.jl

A Julia interface for gzip functions in zlib
https://juliaio.github.io/GZip.jl/dev
MIT License
39 stars 30 forks source link

Try to make tests run on Windows #41

Closed hustf closed 4 years ago

hustf commented 9 years ago

This effort stranded on 

ccall(:dup, Int32, (Int32,) fd) on GZip.jl:278
could not load symbol "dup" on Windows, not on OSX.

Libz is planned to replace Gzip. This is submitted in case this is picked up again for some reason.

simonster commented 9 years ago

Travis doesn't support Windows.

kmsquire commented 9 years ago

@hustf, it seems that travis doesn't like tabs in the .travis.yml.

ranjanan commented 8 years ago

Bump!

Can this PR be rebased? I noticed @tkelman enabled Appveyor, so can we enable it for this PR and then tag a new release?

@bmharsha, is this a fix for #48 ?

hustf commented 8 years ago

I´ll do that, and see if #48 is affected before and after.

hustf commented 8 years ago

The first test (line 49) is not mean to be run if gunzip.exe is not present. But is there any point in keeping it around for other OS?

It runs the standalone program gunzip.exe with command line options. On Windows, it could be identified using 'where.exe gunzip.exe', if it happens to be on PATH. Or we could use something like JULIA_HOME..\Git\Gunzip.exe.

The .exe file was included with Julia until 0.4.0 rc4 and possibly a bit longer. Now, it's not included anymore. The library that is actually used ("zlib1" on Windows) is independent of Gunzip.exe. So this is an irrelevant test as far as I can see. I suppose this is the case for other OSs as well?

tkelman commented 8 years ago

I think the package only uses the library, but the tests use the executable for verification?

tkelman commented 8 years ago

on 0.5, you should be able to run busybox gunzip on windows but that won't work elsewhere if busybox is not installed. the git paths changed between 0.4.0 and 0.4.1, they're kind of internal programs but okay for testing.

hustf commented 8 years ago

Thanks for the info about busybox. I kept the gunzip test on unix. Line 57; gzfdio or gzdopen. This is not found in the windows library. This is not a test of the library, so I find it unreasonable to signal a failed check here.

kmsquire commented 8 years ago

There's a merge conflict, currently, so AppVeyor can't run. Can you rebase on master?

hustf commented 8 years ago

kmsquire, thanks for input, tabs are replaced with spaces now. Note to self, next time: 1) Rebase forked master. 2) Rebase forked branch with forked master 3) Make sure everything is totally up to date 4) Check out branch, work, commit, git push origin

tkelman commented 8 years ago

A bunch of unrelated commits are now in here. Could you rebase again, check that your local branch only has your commits on top of the current master, then be sure to force push over your fork's branch?

hustf commented 8 years ago

Tony, that´s right. Like the January 9 committs are now referred here. That´s an uninteded result of rebasing my fork master, then rebasing my brach fixDep. But I´m afraid I don´t know how to force push. It would be easier for me to delete this and start over with a new fork, unless you have the exact commands in front of you?

tkelman commented 8 years ago

push with the --force flag

hustf commented 8 years ago

I guess that is it now....? Merge?

SimonDanisch commented 8 years ago

there are a typos in: https://github.com/hustf/GZip.jl/blob/03ea8ad49fe0fdfaf7e7c2ff213fc7ace9846cec/appveyor.yml#L41 https://github.com/hustf/GZip.jl/blob/03ea8ad49fe0fdfaf7e7c2ff213fc7ace9846cec/appveyor.yml#L38 Gzip --> GZip

hustf commented 8 years ago

Simon, thanks, but appveyor was put in this PR and also merged separately while this was still open. I have rebased to make the history as clear as possible. There are many improvements which could be made here, but I believe in making short and uncomplicated pull requests (in cases like this, that is!).

kmsquire commented 4 years ago

Windows tests have been working for a while now.