search

JuliaIO / GZip.jl

A Julia interface for gzip functions in zlib
https://juliaio.github.io/GZip.jl/dev
MIT License
39 stars 30 forks source link

Remove deprecated FileOffset #46

Closed yuyichao closed 8 years ago

yuyichao commented 8 years ago

sizeof(z_off_t) detection shouldn't rely on the sizeof(off_t) julia is compiled with.

Ref JuliaLang/julia#14590

yuyichao commented 8 years ago

Hmmm, Appveyor seems to have a hard time starting the test.

Build started
git clone -q --branch=yyc/dep-off_t https://github.com/JuliaLang/GZip.jl.git C:\projects\gzip-jl
git checkout -qf 5ae7f0467990940683e87fae935df07c0b78fed1
Specify a project or solution file. The directory does not contain a project or solution file.

And it seems like it has always been like that @tkelman (do I need to update any settings?)

Travis PR nightly seems to be hitting a error in Coverage.jl likely because of a missing deprecation method that should be fixed on master but maybe not yet in the latest nightly binary?

Travis Push OSX seems to have some other network issues....

kmsquire commented 8 years ago

:+1: LGTM