search

JuliaIO / GZip.jl

A Julia interface for gzip functions in zlib
https://juliaio.github.io/GZip.jl/dev
MIT License
39 stars 30 forks source link

Update API for 1.0 #73

Closed staticfloat closed 6 years ago

staticfloat commented 6 years ago

This changes the API a bit, using a read(::GZipStream, String) instead of readstring(::GZipStream)

kmsquire commented 6 years ago

Hi @staticfloat, perhaps use this as a reference for .travis.yml?

https://github.com/JuliaLang/Pkg.jl/blob/master/.travis.yml

staticfloat commented 6 years ago

I've updated the .travis.yml so that it passes. Is there anything else in particular you are requesting @kmsquire?

Also, do my API changes here look reasonable?

kmsquire commented 6 years ago

Hi @staticfloat, nope, no other requests. The only real change I see is making the Z_BIG_BUFSIZE the default for read. I debated doing that when I first created this, and decided against it then, but I think it should be fine.