search

JuliaIO / HDF5.jl

Save and load data in the HDF5 file format from Julia
https://juliaio.github.io/HDF5.jl
MIT License
387 stars 140 forks source link

cleanup test files #1003

Closed t-bltg closed 2 years ago

t-bltg commented 2 years ago

After https://github.com/JuliaIO/HDF5.jl/pull/984. Per https://github.com/JuliaIO/HDF5.jl/pull/984#issuecomment-1204353657.

mkitti commented 2 years ago

I prefer these comments to stay.

musm commented 2 years ago

I appreciate the effort. Although I don't have a problem with this, this just seems like churn without benefit.

mkitti commented 2 years ago

Thank you again for this. Having the utility of having the comments there seems to still outweigh the aesthetics at the moment.

For these to go away, an more effective approach would be to refactor the test sets into smaller sets.