search

JuliaIO / HDF5.jl

Save and load data in the HDF5 file format from Julia
https://juliaio.github.io/HDF5.jl
MIT License
386 stars 140 forks source link

Better error messages when trying to use MPI without a compatible binary #1015

Open simonbyrne opened 1 year ago

simonbyrne commented 1 year ago

This isn't very helpful:

Screen Shot 2022-10-04 at 12 00 11 PM
simonbyrne commented 1 year ago

I guess the solution would be to get rid of the conditional here: https://github.com/JuliaIO/HDF5.jl/blob/259763f719b69f9e7b0f997eb1d8a539c014cc72/src/drivers/drivers.jl#L92

mkitti commented 1 year ago

Maybe we should turn it into and if ... else. If we don't have MPIO, we include another file that returns an error if someone tries to use MPI?

simonbyrne commented 1 year ago

It should throw an error here: https://github.com/JuliaIO/HDF5.jl/blob/0120cb2d32fc8d57727b3dcb17860c63c00a0cd3/src/drivers/mpio.jl#L43-L48