JuliaIO / HDF5.jl

Save and load data in the HDF5 file format from Julia
https://juliaio.github.io/HDF5.jl
MIT License
386 stars 140 forks source link

enable tests for virtual datasets #1018

Closed simonbyrne closed 1 year ago

simonbyrne commented 1 year ago

From https://github.com/JuliaIO/HDF5.jl/pull/1012#discussion_r997583755, I had forgot to enable the tests.

It turns out the docs at https://portal.hdfgroup.org/display/HDF5/H5P_SET_VIRTUAL are wrong, the %b specifier does not take a dimension argument (at least none of the examples do, and it breaks if you attempt to add one).

mkitti commented 1 year ago

I think I'm slightly ahead of you in #1019