Fixes create_dataset for compound types

JuliaIO / HDF5.jl

Save and load data in the HDF5 file format from Julia

https://juliaio.github.io/HDF5.jl

MIT License

383 stars 139 forks source link

Closed tamasgal closed 1 year ago

tamasgal commented 1 year ago

A small fix of create_dataset which choked when passing your own structs.

Closes #1068

mkitti commented 1 year ago

You beat me to it.

mkitti commented 1 year ago

Could you look over #1067 ? I want merge this one and that one together and check the composition.

tamasgal commented 1 year ago

Ah, I missed that one 😉 I'll have a look.

tamasgal commented 1 year ago

I confirm that all tests pass after merging this (#1069) into #1067.

Test Summary: | Pass  Broken  Total   Time
HDF5.jl       | 1119       5   1124  47.4s
     Testing HDF5 tests passed

tamasgal commented 1 year ago

Do you need anything else? ;)

mkitti commented 1 year ago

Just need to look into the JLD thing.

mkitti commented 1 year ago

OK the JLD tests finally passed. Let's merge.

tamasgal commented 1 year ago

What do you think about a patch release, now with the strings and this being fixed?