search

JuliaIO / ImageMagick.jl

Thin Wrapper for the library ImageMagick
Other
53 stars 37 forks source link

Fix path encoding problems on Windows #144

Open azurefx opened 5 years ago

azurefx commented 5 years ago

See discussions on JuliaImages/Images.jl Issue 770

azurefx commented 5 years ago

Calling setimagefilename() will break TIFF images. Investigating.

timholy commented 4 years ago

Let's try rebuilding this.

codecov[bot] commented 4 years ago

Codecov Report

Merging #144 into master will increase coverage by 7.58%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   53.26%   60.85%   +7.58%     
==========================================
  Files           2        2              
  Lines         306      304       -2     
==========================================
+ Hits          163      185      +22     
+ Misses        143      119      -24
Impacted Files Coverage Δ
src/libmagickwand.jl 57.69% <100%> (+2.25%) :arrow_up:
src/ImageMagick.jl 65.57% <0%> (+15.57%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c4e1c1...69206af. Read the comment docs.

ViralBShah commented 9 months ago

Merge? Or too old and close?

ViralBShah commented 9 months ago 
3D TIFF: Error During Test at /home/runner/work/ImageMagick.jl/ImageMagick.jl/test/constructed_images.jl:142
  Got exception outside of a @test
  Sanity check on directory count failed, this is probably not a valid IFD offset. `TIFFFetchDirectory' @ error/tiff.c/TIFFErrors/567
ViralBShah commented 2 weeks ago

Would be nice to have this one working since it fixes a commonly reported issue (but this PR needs more work).