search

JuliaIO / ImageMagick.jl

Thin Wrapper for the library ImageMagick
Other
53 stars 37 forks source link

A compat release for older versions of Julia #186

Closed timholy closed 4 years ago

timholy commented 4 years ago

xref https://github.com/JuliaRegistries/General/pull/11114

johnnychen94 commented 4 years ago

IMO it would be better to not depend on colortypes and fixedpointnumbers and set ImageCore to 0.8.1

Seems that ImageMagick doesn't have a CompatHelper yet

Cref: https://github.com/JuliaIO/QuartzImageIO.jl/pull/66

timholy commented 4 years ago

Yeah, good idea, that's better than just modernizing the existing dependencies.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (release-0.7@bc8a0e4). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-0.7     #186   +/-   ##
==============================================
  Coverage               ?   72.43%           
==============================================
  Files                  ?        2           
  Lines                  ?      370           
  Branches               ?        0           
==============================================
  Hits                   ?      268           
  Misses                 ?      102           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc8a0e4...20526bc. Read the comment docs.

timholy commented 4 years ago

Since this will affect tests in many packages, i'll merge this tomorrow unless objections emerge.

johnnychen94 commented 4 years ago

compat helper added in #187