search

JuliaIO / ImageMagick.jl

Thin Wrapper for the library ImageMagick
Other
53 stars 37 forks source link

pass extra save_stream keywords to image2wand #199

Closed johnnychen94 closed 3 years ago

johnnychen94 commented 3 years ago

Similar to the save_ method for filename, this PR passes extra keywords to image2wand. An example of this is a stream gif saving with fps keyword. (https://github.com/JuliaImages/ImageShow.jl/pull/30/)

Also fixes a FileIO depwarn in the tests.

codecov[bot] commented 3 years ago

Codecov Report

Merging #199 (3d6cb56) into master (47fdb39) will increase coverage by 4.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   70.52%   74.58%   +4.05%     
==========================================
  Files           3        3              
  Lines         397      421      +24     
==========================================
+ Hits          280      314      +34     
+ Misses        117      107      -10
Impacted Files Coverage Δ
src/ImageMagick.jl 84.21% <100.00%> (+8.68%) :arrow_up:
src/precompile.jl 82.05% <0.00%> (+0.97%) :arrow_up:
src/libmagickwand.jl 66.95% <0.00%> (+1.51%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 47fdb39...3d6cb56. Read the comment docs.

johnnychen94 commented 3 years ago

The failure in ubuntu is reproducible locally and seems to be an SSL certificate issue.

julia> download("http://magnushoff.com/assets/test-exiforientation.zip")
┌ Error: Download failed: curl: (60) SSL certificate problem: unable to get local issuer certificate
└ @ Base download.jl:43
ERROR: failed process: Process(`curl -s -S -g -L -f -o /tmp/jl_3ekIQ8 http://magnushoff.com/assets/test-exiforientation.zip`, ProcessExited(60)) [60]
timholy commented 3 years ago

The failure in ubuntu is reproducible locally and seems to be an SSL certificate issue.

Interesting. Can we generate a "data artifact" and stop worrying about downloading this freshly each time? I haven't really followed that world very well.

johnnychen94 commented 3 years ago

This file is only 4Kb (less than the 4kb block size) so I think we're good to commit it to the git?

timholy commented 3 years ago

That works for me unless there's some license/whatever reason that we can't.