Open simeonschaub opened 1 year ago
Base: 73.93% // Head: 66.96% // Decreases project coverage by -6.97%
:warning:
Coverage data is based on head (
1d11825
) compared to base (079d62b
). Patch coverage: 92.85% of modified lines in pull request are covered.:exclamation: Current head 1d11825 differs from pull request most recent head 6fe954c. Consider uploading reports for the commit 6fe954c to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
LGTM, thanks!
No strong feelings about a test file, other than it should be reasonably small and with unproblematic license. Wikimedia has a few, this one seems appropriate: https://commons.wikimedia.org/wiki/File:FLAT_-_What_is_Creative_Commons.pdf
PDFs are currently always read with the default DPI of 72, which is not particularly high. This allows manually specifying it using the
dpi
keyword. Still needs a test, is there a good sample PDF document I could use for this?cc @timholy