JuliaIO / ImageMagick.jl

Thin Wrapper for the library ImageMagick
Other
53 stars 37 forks source link

bump ImageMagick_jll, add test for #206 #215

Closed simeonschaub closed 6 months ago

simeonschaub commented 1 year ago

should also fix #158

simeonschaub commented 1 year ago

Ah, I see, it's not tagged yet, Yggdrasil is still busy: https://buildkite.com/julialang/yggdrasil/builds/607

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (36f956f) 75.73% compared to head (77b778d) 75.51%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #215 +/- ## ========================================== - Coverage 75.73% 75.51% -0.23% ========================================== Files 3 3 Lines 441 441 ========================================== - Hits 334 333 -1 - Misses 107 108 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

simeonschaub commented 1 year ago

Unfortunately with the latest Ghostscript changes, loading a PDF now segfaults even if you have commandline gs available. @giordano Should we yank the latest ImageMagick_jll? Not really urgent though since ImageMagick.jl still caps the compat

giordano commented 1 year ago

Yes, it'd be good not to have totally unusable versions around.

simeonschaub commented 1 year ago

Ok, everything should be ready to go now

simeonschaub commented 1 year ago

Wait, may have spoken too soon... https://github.com/JuliaIO/ImageMagick.jl/actions/runs/4098160637/jobs/7067061198

giordano commented 1 year ago

Time for https://github.com/giordano/DependencyWalker.jl

simeonschaub commented 1 year ago

Do I need to be on a Windows system for that?

giordano commented 1 year ago

Yes. But you can use https://github.com/mxschmitt/action-tmate to get one

giordano commented 1 year ago

Well, there isn't much to do:

% file libgs-9.dll
libgs-9.dll: broken symbolic link to libgs-9-55.dll
simeonschaub commented 1 year ago

So is the issue that we forgot to copy the original file?

jochalek commented 1 year ago

Is there anything still holding this up? I would like to help if possible.

ViralBShah commented 6 months ago

I'm merging this in order to get things working on M1. Since all tests are passing here, I feel comfortable doing so - but should be easy enough to revert or update further.

ViralBShah commented 6 months ago

Fixes #226