search

JuliaIO / JLD.jl

Saving and loading julia variables while preserving native types
MIT License
277 stars 55 forks source link

Ditch Compat, LegacyStrings #276

Closed timholy closed 4 years ago

timholy commented 4 years ago

LegacyStrings has never been released with a Project.toml. This removes it from the package, but with a cost: no support for UTF-16 strings. The fact that LegacyStrings has never been updated might be a sign that it is not in high demand.

This also removes the dependency on Compat, and modernizes some elements of the package.

codecov[bot] commented 4 years ago

Codecov Report

Merging #276 into master will decrease coverage by 2.00%. The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   71.87%   69.87%   -2.01%     
==========================================
  Files           4        4              
  Lines        1522     1590      +68     
==========================================
+ Hits         1094     1111      +17     
- Misses        428      479      +51
Impacted Files Coverage Δ
src/JLD.jl 88.76% <75.00%> (-0.82%) :arrow_down:
src/jld_types.jl 93.81% <92.30%> (+0.32%) :arrow_up:
src/JLD00.jl 33.91% <100.00%> (-2.48%) :arrow_down:
src/datafile.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5a9863...2fb1447. Read the comment docs.