search

JuliaIO / JLD.jl

Saving and loading julia variables while preserving native types
MIT License
278 stars 55 forks source link

Prepare package for Julia v1.7 #302

Closed nandoconde closed 2 years ago

nandoconde commented 2 years ago

Change T.mutable for ismutabletype

nandoconde commented 2 years ago

Weird Error in nightly builds for Linux and macOS, but Windows is OK, so everything seems fine.

nandoconde commented 2 years ago

@timholy @simonster

timholy commented 2 years ago

Let's get the Compat PR https://github.com/JuliaLang/Compat.jl/pull/759 merged first and then rework this to use Compat.

timholy commented 2 years ago

FYI @nandoconde, I officially retired from maintaining this package a long time ago, so long ago that I can't even remember where I posted the announcement. (I started too many :smile:.) Likewise, Simon is on to other things. https://github.com/orgs/JuliaIO/people has a list of potential alternatives.

nandoconde commented 2 years ago

Thank you both for the review!!

As soon as https://github.com/JuliaLang/Compat.jl/pull/759 is merged, I will use it to improve this one.

timholy commented 2 years ago

https://github.com/JuliaRegistries/General/pull/47757

mauro3 commented 2 years ago

It would be good to get this done now that 1.7 is out.

musm commented 2 years ago

fixed by https://github.com/JuliaIO/JLD.jl/pull/303