Closed JonasIsensee closed 1 month ago
Base: 88.57% // Head: 83.26% // Decreases project coverage by -5.30%
:warning:
Coverage data is based on head (
3abc785
) compared to base (35baacc
). Patch coverage: 0.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hey @oxinabox, your ridiculously fast response to me closing issue #57 inspired me to give this some thought again. I'm still not sure what the best option is or whether there's a good way to integrate JLD2/HDF5 as an "object" format in JLSO.
However, I noticed that I can actually add some of the nice features of JLSO to JLD2 with fairly little effort. Just pinging for your thoughts / opinion
I think this is a nice idea
This is a demonstration implementation of two things inspired by
JLSO.jl
It adds definition
write_env(f)
,has_env(f)
,read_env(f)
andPkg.activate(f::JLDFile)
to write, check, read, and activate an environment stored in a file.It also adds a proof of concept custom serialization
Blob
.Blob
has a single field of typeAny
that gets serialized usingSerialization.serialize
.alternatively write
jldsave("test.jld2"; a=JLD2.Blob(()->rand(3,3)))
a proper API for wrapping and unwrapping in
Blob
s could of course be built.EDIT: it might be better to store the enviroment metadata as attributes.