search

JuliaIO / JLD2.jl

HDF5-compatible file format in pure Julia
Other
549 stars 85 forks source link

make old varargs loadable #394

Closed JonasIsensee closed 1 year ago

JonasIsensee commented 2 years ago

This is a rather frustrating edge case.

I'm not certain this should be merged.

codecov[bot] commented 2 years ago

Codecov Report

Merging #394 (0ade23d) into master (333c916) will decrease coverage by 0.17%. The diff coverage is 30.00%.

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
- Coverage   88.94%   88.77%   -0.18%     
==========================================
  Files          29       29              
  Lines        2895     2903       +8     
==========================================
+ Hits         2575     2577       +2     
- Misses        320      326       +6
Impacted Files Coverage Δ
src/data/reconstructing_datatypes.jl 75.67% <30.00%> (-1.25%) :arrow_down:
src/data/writing_datatypes.jl 97.12% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 333c916...0ade23d. Read the comment docs.