Closed ranocha closed 2 years ago
Merging #412 (643ab44) into master (10ff8b7) will decrease coverage by
0.42%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #412 +/- ##
==========================================
- Coverage 88.91% 88.49% -0.43%
==========================================
Files 29 29
Lines 2896 2894 -2
==========================================
- Hits 2575 2561 -14
- Misses 321 333 +12
Impacted Files | Coverage Δ | |
---|---|---|
src/mmapio.jl | 91.27% <0.00%> (-3.36%) |
:arrow_down: |
src/stdlib.jl | 38.23% <0.00%> (-2.95%) |
:arrow_down: |
src/Lookup3.jl | 82.71% <0.00%> (-2.47%) |
:arrow_down: |
src/bufferedio.jl | 86.36% <0.00%> (-2.28%) |
:arrow_down: |
src/compression.jl | 93.33% <0.00%> (-0.75%) |
:arrow_down: |
src/groups.jl | 85.49% <0.00%> (-0.31%) |
:arrow_down: |
src/data/reconstructing_datatypes.jl | 76.61% <0.00%> (-0.08%) |
:arrow_down: |
src/data/writing_datatypes.jl | 97.11% <0.00%> (-0.01%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Thank you @ranocha !
This is based on https://github.com/julia-actions/julia-invalidations. Adding such checks came up in https://discourse.julialang.org/t/potential-performance-regressions-in-julia-1-8-for-special-un-precompiled-type-dispatches-and-how-to-fix-them/86359. I suggest to add this check here since this package is widely used as a dependency.
See also SciML/MuladdMacro.jl#26 and SciML/MuladdMacro.jl#29