search

JuliaIO / JLD2.jl

HDF5-compatible file format in pure Julia
Other
549 stars 85 forks source link

make compress doc more visible #423

Closed xgdgsc closed 1 year ago

xgdgsc commented 1 year ago

I would consider making compress enabled the default behavior.

codecov[bot] commented 1 year ago

Codecov Report

Base: 84.06% // Head: 84.06% // No change to project coverage :thumbsup:

Coverage data is based on head (6cd72b5) compared to base (fb5f9af). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #423 +/- ## ======================================= Coverage 84.06% 84.06% ======================================= Files 30 30 Lines 4097 4097 ======================================= Hits 3444 3444 Misses 653 653 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

JonasIsensee commented 1 year ago

thank you for this improvement.

I have considered it in the past but don't think it would be a good idea as default. Compression requires an additional dependency and is not always useful. Depending on the data it can even be counter-productive.