Closed eschnett closed 1 year ago
Base: 84.09% // Head: 84.07% // Decreases project coverage by -0.02%
:warning:
Coverage data is based on head (
904a3e6
) compared to base (cdf2ab8
). Patch coverage: 88.88% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
The failing check is a spurious small apparent reduction in coverage because codecov miscounts some function metadata. There is no actual reduction in coverage.
Hi @eschnett, thanks a lot for figuring this out!
This issue resurfaced because julia compat was not updated https://github.com/JuliaRegistries/General/pull/93505
It'd be appreciated if package developers proactively added appropriate compat bounds in the registry to avoid troubles to users, when they fix errors like this one.
Hi @giordano ,
I'm aware of the problem but don't have a proper solution.
Can I limit the compat on Julia (by default on the current minor version) without preventing tests on nightly?
Should I just manually keep track of problems and make handcrafted pull requests to the registry?
We already fixed it in the PR linked above: https://github.com/JuliaRegistries/General/pull/93505. That was more a suggestion for the future.
Sure, I was just wondering whether I can prevent his from happening again or whether the best/only option is for me to create such a PR next time.
The current JLD2 release claims to be compatible with all future 1.x releases which is probably not correct. (Since it relies on Julia internals and I don't think it's possible to get rid of this entirely)
Ideally you wouldn't use julia's internals. If that's really not possible, when you become aware of some breakage, like #428, it'd be good to do a PR to General like the one linked above, to prevent the package to be installed on incompatible versions of julia.
Closes https://github.com/JuliaIO/JLD2.jl/issues/428.