JuliaIO / JLD2.jl

HDF5-compatible file format in pure Julia
Other
547 stars 85 forks source link

allow loading compressed files during precompilation #446

Closed marius311 closed 1 year ago

marius311 commented 1 year ago

If you try to load a compressed file during precompilation (like top-level of your module, or in a SnoopPrecompile.@precompile_all_calls), the @eval s were causing an error since you're evaling into another module which is not allowed. You can just getproperty directly I think, works for my case, will wait for full suite of tests below to see if there's not some edge case.

codecov[bot] commented 1 year ago

Codecov Report

Base: 84.06% // Head: 83.50% // Decreases project coverage by -0.56% :warning:

Coverage data is based on head (2a4f3b4) compared to base (7ed395e). Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #446 +/- ## ========================================== - Coverage 84.06% 83.50% -0.57% ========================================== Files 30 30 Lines 4136 4135 -1 ========================================== - Hits 3477 3453 -24 - Misses 659 682 +23 ``` | [Impacted Files](https://codecov.io/gh/JuliaIO/JLD2.jl/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO) | Coverage Δ | | |---|---|---| | [src/compression.jl](https://codecov.io/gh/JuliaIO/JLD2.jl/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO#diff-c3JjL2NvbXByZXNzaW9uLmps) | `89.90% <50.00%> (ø)` | | | [src/data/type\_defs.jl](https://codecov.io/gh/JuliaIO/JLD2.jl/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO#diff-c3JjL2RhdGEvdHlwZV9kZWZzLmps) | `66.66% <0.00%> (-22.23%)` | :arrow_down: | | [src/mmapio.jl](https://codecov.io/gh/JuliaIO/JLD2.jl/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO#diff-c3JjL21tYXBpby5qbA==) | `80.40% <0.00%> (-10.87%)` | :arrow_down: | | [src/dataio.jl](https://codecov.io/gh/JuliaIO/JLD2.jl/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO#diff-c3JjL2RhdGFpby5qbA==) | `93.66% <0.00%> (-2.12%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

marius311 commented 1 year ago

Any chance to get this merged/released? Anecdotally its been fine for me in all my work this week.

JonasIsensee commented 1 year ago

Hi @marius311 , thanks for the ping. I just forgot about this. Will be tagging a release now.