Closed dpinol closed 1 year ago
ha, you're right. I remember finding this myself at some point. HDF5 has a built-in time datatype that apparently no-one ever uses and I half-built support for it. Not really sure what's best here. One could properly implement it with it most likely never being used or one could remove the type with a proper "NotImplementedError"
raising NotImplementedError sounds fine. I can create a MR throwing NotImplementedError from read_datatype in you find it ok
Please do! :)
In fact, a UnsupportedFeatureException("some explanation")
would probably be best.
@JonasIsensee done!
macro
read_datatype
indatatypes.jl
usesTimeDatatype
, which is not defined anywhere.The issue is reported by JET