JuliaIO / JLD2.jl

HDF5-compatible file format in pure Julia
Other
537 stars 84 forks source link

Can't upgrade parametric types #475

Closed JonasIsensee closed 11 months ago

JonasIsensee commented 1 year ago

previously it tried to to do

Upgrade(NewStruct){OldStructparams....}

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 :tada:

Comparison is base (d5b7b1c) 86.06% compared to head (b4f34f4) 86.09%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #475 +/- ## ========================================== + Coverage 86.06% 86.09% +0.03% ========================================== Files 31 31 Lines 4169 4171 +2 ========================================== + Hits 3588 3591 +3 + Misses 581 580 -1 ``` | [Impacted Files](https://app.codecov.io/gh/JuliaIO/JLD2.jl/pull/475?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO) | Coverage Δ | | |---|---|---| | [src/data/reconstructing\_datatypes.jl](https://app.codecov.io/gh/JuliaIO/JLD2.jl/pull/475?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO#diff-c3JjL2RhdGEvcmVjb25zdHJ1Y3RpbmdfZGF0YXR5cGVzLmps) | `81.89% <100.00%> (+0.05%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/JuliaIO/JLD2.jl/pull/475/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.