JuliaIO / JLD2.jl

HDF5-compatible file format in pure Julia
Other
553 stars 88 forks source link

Don't keep file in open files cache if it fails to read metadata #483

Closed Keno closed 1 year ago

Keno commented 1 year ago

Fixes https://github.com/JuliaPackaging/BinaryBuilder.jl/issues/1292

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -2.11% :warning:

Comparison is base (68481f9) 85.91% compared to head (39c205d) 83.80%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #483 +/- ## ========================================== - Coverage 85.91% 83.80% -2.11% ========================================== Files 31 31 Lines 4223 4032 -191 ========================================== - Hits 3628 3379 -249 - Misses 595 653 +58 ``` | [Files Changed](https://app.codecov.io/gh/JuliaIO/JLD2.jl/pull/483?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO) | Coverage Δ | | |---|---|---| | [src/JLD2.jl](https://app.codecov.io/gh/JuliaIO/JLD2.jl/pull/483?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO#diff-c3JjL0pMRDIuamw=) | `88.51% <100.00%> (-1.16%)` | :arrow_down: | ... and [27 files with indirect coverage changes](https://app.codecov.io/gh/JuliaIO/JLD2.jl/pull/483/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JonasIsensee commented 1 year ago

Thanks!

I fixed the typo in the tests and tagged a patch release.