JuliaIO / JLD2.jl

HDF5-compatible file format in pure Julia
Other
537 stars 84 forks source link

fix iddicts #499

Closed JonasIsensee closed 8 months ago

JonasIsensee commented 8 months ago

I think, this change should do it - i.e. expand the writeas applicability for IdDicts.

The change below that is mostly just a cleanup.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d63e102) 85.95% compared to head (23af351) 85.86%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #499 +/- ## ========================================== - Coverage 85.95% 85.86% -0.10% ========================================== Files 31 31 Lines 4230 4224 -6 ========================================== - Hits 3636 3627 -9 - Misses 594 597 +3 ``` | [Files](https://app.codecov.io/gh/JuliaIO/JLD2.jl/pull/499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO) | Coverage Δ | | |---|---|---| | [src/data/specialcased\_types.jl](https://app.codecov.io/gh/JuliaIO/JLD2.jl/pull/499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO#diff-c3JjL2RhdGEvc3BlY2lhbGNhc2VkX3R5cGVzLmps) | `90.51% <100.00%> (-0.40%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/JuliaIO/JLD2.jl/pull/499/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.