JuliaIO / JLD2.jl

HDF5-compatible file format in pure Julia
Other
534 stars 82 forks source link

Draft: Accepting already open and limited IO types #535

Open JonasIsensee opened 5 months ago

JonasIsensee commented 5 months ago

This adds a method jldopen(::IO, mode; kwargs...) that should take in already opened IOs and figure out what to do with them.

Currently, this PR implements a ReadOnlyBuffer that can wrap another IO object which only supports reading but not seeking. Therefore it reads linearly and buffers everything in between.

Referencing

346

233

304

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 85.26786% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 86.51%. Comparing base (15eaa50) to head (440b29a). Report is 28 commits behind head on master.

Files Patch % Lines
src/compression.jl 4.54% 21 Missing :warning:
src/general_io.jl 94.27% 11 Missing :warning:
src/JLD2.jl 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #535 +/- ## ========================================== - Coverage 86.81% 86.51% -0.30% ========================================== Files 31 32 +1 Lines 4299 4539 +240 ========================================== + Hits 3732 3927 +195 - Misses 567 612 +45 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.