search

JuliaIO / JSON.jl

JSON parsing and printing
Other
313 stars 101 forks source link

Add singleton support #331

Open Wynand opened 2 years ago

Wynand commented 2 years ago

Currently singletons don't work with lower, and this adds support for that

Effectively the singletons are printed as their class with "()" as a suffix to show that they're an instance of the singleton instead of the singleton type

codecov[bot] commented 2 years ago

Codecov Report

Merging #331 (2258c48) into master (f93688a) will decrease coverage by 0.19%. The diff coverage is 85.71%.

:exclamation: Current head 2258c48 differs from pull request most recent head 00e171f. Consider uploading reports for the commit 00e171f to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
- Coverage   99.51%   99.31%   -0.20%     
==========================================
  Files           5        5              
  Lines         410      440      +30     
==========================================
+ Hits          408      437      +29     
- Misses          2        3       +1
Impacted Files Coverage Δ
src/Writer.jl 97.45% <85.71%> (-0.68%) :arrow_down:
src/Parser.jl 100.00% <0.00%> (ø)
src/specialized.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f93688a...00e171f. Read the comment docs.

Wynand commented 2 years ago

This issue may be relevant: https://github.com/JuliaIO/JSON.jl/issues/203