search

JuliaIO / JSON.jl

JSON parsing and printing
Other
313 stars 101 forks source link

Update doc with correct parameterized function syntax #336

Closed o314 closed 2 years ago

o314 commented 2 years ago

This format is not supported since a long time. Should we remap Associative to AbstractDict too ?

codecov[bot] commented 2 years ago

Codecov Report

Merging #336 (2833533) into master (f93688a) will decrease coverage by 0.87%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
- Coverage   99.51%   98.63%   -0.88%     
==========================================
  Files           5        5              
  Lines         410      441      +31     
==========================================
+ Hits          408      435      +27     
- Misses          2        6       +4
Impacted Files Coverage Δ
src/Parser.jl 100.00% <ø> (ø)
src/JSON.jl 20.00% <0.00%> (-80.00%) :arrow_down:
src/specialized.jl 100.00% <0.00%> (ø)
src/Writer.jl 98.26% <0.00%> (+0.13%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f93688a...2833533. Read the comment docs.

singularitti commented 2 years ago

Hi, I guess you should also align the first line like parse(str::AbstractString; with the rest of the lines.

o314 commented 2 years ago

This should be done now. Nota that mentions to Associative have not been reviewed