Closed xhochy closed 10 years ago
I'm now at the stage where I think this PR is for final review/merge. If it gets accepted I'd work on migrating the ETree parsing process to this streaming backend to avoid further code duplication.
I am OK with merging this. Could you rebase and squash your commits?
@vtjnash comments?
Squash, rebased and added the missing xml test file
seems like a good idea to me. the only thing i would suggest is shortening the method names by removing xp
and streaming
. In C, these are needed to distinguish the method call, but in Julia, they just makes it harder to have reusable interfaces.
@vtjnash You mean: renaming xp_streaming_parse
to parse
?
yes, but also parsefile, start, pause, stop, etc
Removed useless ::Function
and xp_streaming_
prefixes
Thanks Jameson. Will merge this in a few hours if there are no more concerns.
And thanks @xhochy for this feature. Do tag and bump the version in METADATA whenever you are ready.
I started work on implementing streaming XML parsing. There is still a lot of work to do but I really would appreciate early feedback so that I can develop in the right direction.
Very basic usage which highlights my current architecture choices: