Use a typealias for Tuple{Symbol,Any} to resolve properly in macros

JuliaIO / LibExpat.jl

Julia interface to the Expat XML parser library

Other

9 stars 32 forks source link

Use a typealias for Tuple{Symbol,Any} to resolve properly in macros #29

Closed tkelman closed 9 years ago

tkelman commented 9 years ago

fixes #28

tkelman commented 9 years ago

this passes on both 0.3 and 0.4 for me locally, on ubuntu 14.04

tkelman commented 9 years ago

I tried making a separate branch to test the docker worker, and unfortunately it still segfaults there... https://travis-ci.org/amitmurthy/LibExpat.jl/jobs/59514942

amitmurthy commented 9 years ago

LGTM. Please go ahead and merge.

tkelman commented 9 years ago

Thanks. It doesn't segfault when I locally run a docker container of Ubuntu precise, and download the same Julia nightly. Something particular about the Travis image I guess?

amitmurthy commented 9 years ago

I guess. Similar unexplained segfault in HTTPClient too.