search

JuliaIO / LibExpat.jl

Julia interface to the Expat XML parser library
Other
9 stars 32 forks source link

removed warnings + imported base functions #32

Closed SimonDanisch closed 9 years ago

SimonDanisch commented 9 years ago

Uhm, just noticed I already made a pull request for this that never got merged.... Well this one has some more additions.

SimonDanisch commented 9 years ago

still segfaulting, great :D

SimonDanisch commented 9 years ago

Hi, can this get merged and tagged, since it seems like the segfault is unrelated?! Would be lovely not to have one gazillion warnings when building something ;) It gives you that uneasy feel even if the build is successful.

Thanks, Simon

yuyichao commented 9 years ago

Note that with recently added deprecation warnings this is making WinRPM output on AppVeyor unreadable e.g. .

EricForgy commented 9 years ago

Out of curiosity, what is holding up this pull request?

I'm new to Github and Julia and when I saw the deprecation warning on master, I wrongfully presumed that if it was still on master I should go ahead and fix it and submit a pull request (trying to do whatever little I can to help out). Then I subsequently learned that another pull request fixing the same thing was submitted 25 days ago.

I see checks are failing but that seems to not be related to the pull request. Still learning the ropes so thanks for patience :)

tkelman commented 9 years ago

Cc @amitmurthy please go through these

edit: I completely forgot that apparently I have commit access here, could still use help debugging the segfault though

tkelman commented 9 years ago

included (and tweaked a little) in #37