search

JuliaIO / LibExpat.jl

Julia interface to the Expat XML parser library
Other
9 stars 32 forks source link

Remove unnecessary compat macro #61

Closed musm closed 7 years ago

musm commented 7 years ago

I think these were needed for 0.3? but the tests pass on 0.4 and 0.5 so I think we can remove them now.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 28.657% when pulling a5037fbb4b53ed3796e72c3068a2f9b5b2fb9ba9 on musm:compat-up into bb3eeacbc4b5b3dc3fda41de54d9d9dfb5899104 on amitmurthy:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 28.657% when pulling 61eae31464777664cc39ed1cbebbc558ec7b985f on musm:compat-up into bb3eeacbc4b5b3dc3fda41de54d9d9dfb5899104 on amitmurthy:master.

musm commented 7 years ago

will merge tomorrow sans any objections , test pass except the usually failing master tests, which is unrelated to this change.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 28.657% when pulling 98d76113f6b17cb5a601d71a00854a7db3909e2d on musm:compat-up into 8475a31e06cd0254eb03c7f9b6ee600aee527daa on amitmurthy:master.