Fix another macro hygiene bug and debug flags

JuliaIO / LibExpat.jl

Julia interface to the Expat XML parser library

Other

9 stars 32 forks source link

Fix another macro hygiene bug and debug flags #63

Closed musm closed 7 years ago

musm commented 7 years ago

So previously this package wouldn't run with DEBUG = true on 0.5 and 0.6 (also due to another hygiene bug)

musm commented 7 years ago

I have been trying to figure out the failures on 0.6 (new world issue I think...?) to no avail these are just some unrelated issues.

coveralls commented 7 years ago

Coverage decreased (-0.07%) to 28.584% when pulling 358277c4312f68526b3d9c98822811470a47ad70 on musm:master into 8c82be3ab1e790886e3eacbba4430b0af275b2cd on amitmurthy:master.

musm commented 7 years ago

I would be in favor of getting rid of this manual debugging stuff, now that we actually have a debugger that works for O.5. Is that ok with everyone?

amitmurthy commented 7 years ago

Sure.

coveralls commented 7 years ago

Coverage decreased (-1.0%) to 27.704% when pulling 744ae6297c836227eb66c0f60ab9b2d0c1471b87 on musm:master into 8c82be3ab1e790886e3eacbba4430b0af275b2cd on amitmurthy:master.

coveralls commented 7 years ago

Coverage decreased (-1.0%) to 27.704% when pulling 9aa104ed0a59c39eff795e30941835e3a7a695fc on musm:master into 8c82be3ab1e790886e3eacbba4430b0af275b2cd on amitmurthy:master.

coveralls commented 7 years ago

Coverage decreased (-0.9%) to 27.802% when pulling 1c77c8325f02dfd33abfe1adc2ec010fe7f6dfe0 on musm:master into 8c82be3ab1e790886e3eacbba4430b0af275b2cd on amitmurthy:master.