search

JuliaIO / LibExpat.jl

Julia interface to the Expat XML parser library
Other
9 stars 32 forks source link

Fix free type variables #80

Closed musm closed 7 years ago

musm commented 7 years ago

Fix https://github.com/JuliaIO/LibExpat.jl/issues/79 which prevents WinRPM usage.

Won't be adding tests as I don't have interest in doing so, but this was a quick enough fix so thought I'd open a PR.

musm commented 7 years ago

cc @amitmurthy

tkelman commented 7 years ago

this seems like a julia bug, and shouldn't be an error? does it work with @nospecialize ?

musm commented 7 years ago

Not sure what you mean by that, where would you add that?

Using Any instead of ANY seems to fix this...

tkelman commented 7 years ago

ANY has recently been replaced on 0.7 by @nospecialize Any it's not in Compat yet but would make a good addition

musm commented 7 years ago

does it work with @nospecialize ?

yes

tkelman commented 7 years ago

Probably still a bug then, that the deprecation machinery for ANY isn't compatible with how it used to work. Though I don't think ANY in a type parameter here was accomplishing much.

amitmurthy commented 7 years ago

Yes, ANY was probably not relevant here.

tkelman commented 7 years ago

should still be reported as a possible bug in the deprecation

musm commented 7 years ago

Get someone tag this? Seems to be causing issues with other packages that rely on libexpat