Fix use of old iterator protocol for strings

JuliaIO / LibExpat.jl

Julia interface to the Expat XML parser library

Other

9 stars 32 forks source link

Fix use of old iterator protocol for strings #94

Closed bkamins closed 6 years ago

bkamins commented 6 years ago

The patch assumes that xparth_parse_expr correctly uses character indexing (the old version also used this assumption).

ranjanan commented 6 years ago

@bkamins perhaps you can co-opt this PR to upgrade to v0.7/1.0. Could you update Travis to test on v0.7, 1.0 and nightly?

ranjanan commented 6 years ago

Also, can you please update appveyor like this: https://github.com/vtjnash/Glob.jl/blob/e84c7e3c3e03fd89e28c5141ff82ffb9c31038df/.appveyor.yml

bkamins commented 6 years ago

I will not be able to do it today (flying out of London the very moment) so probably it would be faster if this PR is merged and CI configuration is left for another PR (or someone can push to this PR).

ranjanan commented 6 years ago

Okay sure.

bkamins commented 6 years ago

Added travis and appveyor updates.

bkamins commented 6 years ago

CI fails due to unrelated issues AFACT.

ranjanan commented 6 years ago

I've restarted those two suspect jobs.

bkamins commented 6 years ago

Now only one job fails due to timeout.