search

JuliaIO / LibExpat.jl

Julia interface to the Expat XML parser library
Other
9 stars 32 forks source link

Upgrade to 1.3+, use `Expat_jll` to vendor `libexpat` #99

Closed staticfloat closed 5 years ago

staticfloat commented 5 years ago

This will allow Julia 1.3 to stop shipping libexpat with the distribution; the library will be dynamically downloaded and unpacked when needed.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@256ca60). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #99   +/-   ##
=========================================
  Coverage          ?   30.21%           
=========================================
  Files             ?        4           
  Lines             ?     1026           
  Branches          ?        0           
=========================================
  Hits              ?      310           
  Misses            ?      716           
  Partials          ?        0
Impacted Files Coverage Δ
src/LibExpat.jl 81.36% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 256ca60...3b54291. Read the comment docs.

staticfloat commented 5 years ago

Wow, that's quite the drop in coverage.

musm commented 5 years ago

Also this is awesome! I always hated the libexpat shipped dependency just to bootstrap Pkg

SimonDanisch commented 5 years ago

Btw, I just recently run into search still being used in here: https://github.com/JuliaIO/LibExpat.jl/blob/6fe0d71ea2bb52839aa9d13639c1f85bbc9a3562/src/xpath.jl#L1028 That got removed from julia in 1.0... Not sure if we want to fix it here in this PR ;)

SimonDanisch commented 5 years ago

I'm going to merge this if nobody is against it ;)