search

JuliaIO / LightXML.jl

A light-weight Julia package for XML based on libxml2.
MIT License
90 stars 39 forks source link

Move to using jlls #107

Closed aviks closed 4 years ago

aviks commented 4 years ago

lower bound to Julia 1.3 as a result.

omus commented 4 years ago

The CI should be configured to only run on 1.3+

codecov[bot] commented 4 years ago

Codecov Report

Merging #107 into master will decrease coverage by 1.31%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage   78.94%   77.63%   -1.32%     
==========================================
  Files           6        6              
  Lines         152      152              
==========================================
- Hits          120      118       -2     
- Misses         32       34       +2
Impacted Files Coverage Δ
src/LightXML.jl 100% <ø> (ø) :arrow_up:
src/nodes.jl 80.58% <0%> (-1.95%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 666caa7...768d387. Read the comment docs.

aviks commented 4 years ago

All tests now pass, except drone, which failes on armv7 1.4, which hasnt been released yet unfortunately. Would you want to keep that for future use, or disable testing on that platform?

omus commented 4 years ago

I'll make an issue for it but I think we can just leave it as is for now.