Incompatibilities in MAT_v5.jl with v1.0.2

JuliaIO / MAT.jl

Julia module for reading MATLAB files

MIT License

278 stars 71 forks source link

Incompatibilities in MAT_v5.jl with v1.0.2 #104

Closed wg030 closed 5 years ago

wg030 commented 5 years ago

When making my Julia code campatibile with the latest stable version 1.0.2, I have figured out some lines in "MAT_v5.jl" that were still not compatibile, so I have fixed them as follows:

Line 171: field_name_strings = Vector{String}(undef, n_fields) Line 175: index = findfirst(isequal( 0), sname) Line 193: data[field_name] = Array{Any}(undef, dimensions...) Line 260: data = Vector{String}(undef, dimensions[1])

With these modifications at least my code works as before.

mforets commented 5 years ago

I had the same problem when I tried some benchmark suite that depends on MAT in a fresh Julia installation, and I found your suggestions useful 👍

This is of course a tiny fraction of PR https://github.com/JuliaIO/MAT.jl/pull/86. There was some discussion in that thread about splitting it out into smaller pieces. So i opened #106.