Yet another PR for Julia v1

JuliaIO / MAT.jl

Julia module for reading MATLAB files

MIT License

278 stars 71 forks source link

Yet another PR for Julia v1 #110

Closed jaakkor2 closed 5 years ago

jaakkor2 commented 5 years ago

Take master, merge #86, resolve conflicts and remove Compat.

Status 2019-2-18:

Travis passes build job 204
local testing ]test MAT
- windows 7 x64 Julia v1.1 passes

alexcanepa commented 5 years ago

@yuyichao bump on this PR, it's pretty frustrating to depend on forks of this package for usability

jaakkor2 commented 5 years ago

Latest change requests from @yuyichao taken into account. Tests pass on Linux, random fails in osx. Local tests pass on Windows x64 Julia v1.1. Opened https://github.com/JuliaIO/MAT.jl/issues/112 to track the randomly failing travis jobs.

jaakkor2 commented 5 years ago

Close and reopen in hope to trigger another Travis build job

timholy commented 5 years ago

Nice to see this getting over the finish line. I cleaned this up, git history-wise, in #113. We can close this when that merges.

timholy commented 5 years ago

Thanks for your efforts, @jaakkor2 and @yuyichao!