search

JuliaIO / MAT.jl

Julia module for reading MATLAB files
MIT License
278 stars 71 forks source link

v4 support #132

Closed vsaase closed 1 year ago

vsaase commented 4 years ago

Hi, this provides v4 support. I am not yet very experienced with Julia so it might be a bit rough. Comments welcome.

musm commented 3 years ago

Is this good to go?

vsaase commented 3 years ago

I think so. The tests with the set of MAT4 files, which use all functionality of MAT4, passed.

musm commented 3 years ago

This is causing some test failures I think on Julia 1.5.1 on MacOS for some reason: https://travis-ci.org/github/JuliaIO/MAT.jl/jobs/724195833

I'm not sure why exactly this is Mac specific.

musm commented 3 years ago

Actually that error doesn't look related.

musm commented 3 years ago

I guess the only thing I'm not a big fan of is naming it matwrite4

can we not make it kwarg so we can consolidate them all.

sjkelly commented 1 year ago

Supplanted by #186. Thanks for getting the ball rolling here!