search

JuliaIO / MAT.jl

Julia module for reading MATLAB files
MIT License
278 stars 71 forks source link

Pass id rather than object as the 5th argument to h5d_read #141

Closed grero closed 3 years ago

grero commented 4 years ago

This should fix issue #140.

bjarthur commented 4 years ago

while this fixes the first error when i do ]test MAT locally, it doesn't fix the next one:

ERROR: LoadError: LoadError: MethodError: no method matching d_create(::HDF5.HDF5File, ::String, ::Array{UInt16,1}, ::String, ::Array{Int64,1}, ::String, ::Int64)
Closest candidates are:
  d_create(::Union{HDF5.HDF5File, HDF5.HDF5Group}, ::String, ::Type, ::Any, ::String, ::Any, ::Any...) at /groups/scicompsoft/home/arthurb/.julia/dev/HDF5/src/HDF5.jl:948
  d_create(::Union{HDF5.HDF5File, HDF5.HDF5Group}, ::String, ::HDF5.HDF5Datatype, ::HDF5.HDF5Dataspace, ::String, ::Any, ::Any...) at /groups/scicompsoft/home/arthurb/.julia/dev/HDF5/src/HDF5.jl:938
  d_create(::Union{HDF5.HDF5File, HDF5.HDF5Group}, ::String, ::HDF5.HDF5Datatype, ::Tuple{Vararg{Int64,N}} where N, ::String, ::Any, ::Any...) at /groups/scicompsoft/home/arthurb/.julia/dev/HDF5/src/HDF5.jl:946
  ...
Stacktrace:
 [1] m_writearray(::HDF5.HDF5File, ::String, ::Array{UInt16,1}, ::Bool) at /groups/scicompsoft/home/arthurb/.julia/dev/MAT/src/MAT_HDF5.jl:331
 [2] m_write(::MAT.MAT_HDF5.MatlabHDF5File, ::HDF5.HDF5File, ::String, ::UInt16) at /groups/scicompsoft/home/arthurb/.julia/dev/MAT/src/MAT_HDF5.jl:377
 [3] write(::MAT.MAT_HDF5.MatlabHDF5File, ::String, ::UInt16) at /groups/scicompsoft/home/arthurb/.julia/dev/MAT/src/MAT_HDF5.jl:545
 [4] matwrite(::String, ::Dict{String,Real}; compress::Bool) at /groups/scicompsoft/home/arthurb/.julia/dev/MAT/src/MAT.jl:157
 [5] test_write(::Dict{String,Real}; kwargs::Base.Iterators.Pairs{Symbol,Bool,Tuple{Symbol},NamedTuple{(:compress,),Tuple{Bool}}}) at /groups/scicompsoft/home/arthurb/.julia/dev/MAT/test/write.jl:6
 [6] test_write(::Dict{String,Real}) at /groups/scicompsoft/home/arthurb/.julia/dev/MAT/test/write.jl:23
 [7] top-level scope at /groups/scicompsoft/home/arthurb/.julia/dev/MAT/test/write.jl:37
 [8] include(::String) at ./client.jl:457
 [9] top-level scope at /groups/scicompsoft/home/arthurb/.julia/dev/MAT/test/runtests.jl:4
 [10] include(::String) at ./client.jl:457
 [11] top-level scope at none:6
in expression starting at /groups/scicompsoft/home/arthurb/.julia/dev/MAT/test/write.jl:37
in expression starting at /groups/scicompsoft/home/arthurb/.julia/dev/MAT/test/runtests.jl:4
ERROR: Package MAT errored during testing

i'm on master of both MAT and HDF5. strange that travis reports no errors. tests pass locally for you?

jmert commented 3 years ago

CI failures are solved by #142.

musm commented 3 years ago

Does this need to also go in 0.8.1 ?

jmert commented 3 years ago

To avoid the deprecation warnings completely, yes, it should go in the next release. Thanks!