search

JuliaIO / MAT.jl

Julia module for reading MATLAB files
MIT License
278 stars 71 forks source link

Fix for UInt8 error in close() #67

Closed laurentheirendt closed 7 years ago

laurentheirendt commented 7 years ago

Fix for UInt8 error when using close():

ERROR: LoadError: LoadError: type String has no field data
Use `Vector{UInt8}(str)` instead.
Stacktrace:
 [1] close(::MAT.MAT_HDF5.MatlabHDF5File) at /home/vagrant/.julia/v0.6/MAT/src/MAT_HDF5.jl:61

cc: @yuyichao, @simonster, @syarra

laurentheirendt commented 7 years ago

Julia 0.6 and latest commit on the master branch of MAT.jl lead to a failure when closing the .mat file.

The log is here.

yuyichao commented 7 years ago

No it's not the latest commit on master. This just need a tag.

laurentheirendt commented 7 years ago

In the .travis file of the COBRA.jl repository, the latest commit on master is checked out, so how come it is not the latest commit?

Actually, I asked for a new tag a while ago in this issue...

yuyichao commented 7 years ago

PkgEval is not travis.

yuyichao commented 7 years ago

And FWIW your travis did pass https://travis-ci.org/opencobra/COBRA.jl

laurentheirendt commented 7 years ago

Ok, so how can we fix the PkgEval ... ?

yuyichao commented 7 years ago

A tag will fix it. The last tag wasn't made with attobot so it'll be much easier if an admin on this repo enables it.