tests pass in julia 1.0

JuliaIO / MAT.jl

Julia module for reading MATLAB files

MIT License

278 stars 71 forks source link

tests pass in julia 1.0 #91

Closed denizyuret closed 5 years ago

denizyuret commented 6 years ago

Julia 1.0 compatible version.

andreasnoack commented 6 years ago

You'd have to update .travis.yml as well. Could you try removing the script part and enable testing on 1.0?

denizyuret commented 6 years ago

Updated travis.

alyst commented 6 years ago

Looks like CI fails during HDF5.jl installation. I'm not sure what's the issue, but HDF5.jl has

addons:
  apt:
    packages:
    - hdf5-tools

in its .travis.yml

denizyuret commented 6 years ago

I don't think we get an error with the new HDF5 0.10. My tests pass. I updated REQUIRE.

denizyuret commented 6 years ago

CI failed again. This seems to be a problem with CI building HDF5 not being able to download stuff. Builds and tests ok on a regular machine. Can we release this?

alyst commented 6 years ago

It looks like Julia tries to install hdf5-tools during Pkg.build(). IMHO it's still worth to try fixing it by updating travis.yml.

denizyuret commented 6 years ago

How do you suggest we do that?

alyst commented 6 years ago

Just add hdf5-tools as "addon" (see the earlier comment, also HDF5's travis.yml)

denizyuret commented 6 years ago

Seems to fail sporadically.

denizyuret commented 6 years ago

And I can't make it fail on my machine to debug :( Can anybody replicate the CI failure?

quaertym commented 6 years ago

@denizyuret It is possible to ssh to the travis CI machine.

denizyuret commented 6 years ago

@emreunal Can you tell what is causing the issue?

On Wed, Sep 5, 2018 at 2:37 PM Emre Unal notifications@github.com wrote:

@denizyuret https://github.com/denizyuret It is possible to ssh to the travis CI machine.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/JuliaIO/MAT.jl/pull/91#issuecomment-418835965, or mute the thread https://github.com/notifications/unsubscribe-auth/ABvNpsWXKtg4Wi_IBgol1mDTYtxgjJFLks5uYBntgaJpZM4WFE3i .